-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated CHANGES.md #243
Updated CHANGES.md #243
Conversation
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
======================================
Coverage 39.4% 39.5%
======================================
Files 99 99
Lines 3641 3633 -8
Branches 587 587
======================================
- Hits 1438 1437 -1
+ Misses 1798 1791 -7
Partials 405 405
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Greg!
- Tendermint-Go v0.33 compatibility - issue #184 | ||
- `abci_info`, `abci_query`, `block_results`, `genesis` structs | ||
- serialization/deserialization fixes | ||
- Updated/fixed integration tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CHANGES.md
Outdated
## [Pending next release] | ||
|
||
RPC changes: | ||
- Tendermint-Go v0.33 compatibility - issue #184 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: don't we want to keep referencing and linking to issues consistent? See previous entries:
https://github.com/informalsystems/tendermint-rs/pull/243/files#diff-8b1c3fd0d4a6765c16dfd18509182f9dR18
https://github.com/informalsystems/tendermint-rs/pull/243/files#diff-8b1c3fd0d4a6765c16dfd18509182f9dR21
CHANGES.md
Outdated
- serialization/deserialization fixes | ||
- Updated/fixed integration tests | ||
|
||
CI changes: - issue #120 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above (referencing and linking).
CI changes: - issue #120 | ||
- Moved to GitHub Actions | ||
- Updated crates.io badges | ||
- Enabled integration tests in CI with Tendermint-Go node service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how relevant CI changes are to readers of the changelog because these do not have any effect on users of tendermint-rs. On the other hand it's probably good to communicate what happened since the last release anyways. Note that the other badges were also updated in a another PR/issue.
Updated the CHANGES file to match the format previously agreed. Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Note that links are done slightly different in this PR than previously, e.g see:
Now the links are directly embedded in the text (rendered both look the same; the former is easier to read if not rendered though). |
Updates to CHANGES.md: added the changes implemented in the earlier Tendermint/v0.33 change.